Idiomatic: Various tweaks and cleanup to naming conventions section#3164
Open
randomPoison wants to merge 2 commits intogoogle:mainfrom
Open
Idiomatic: Various tweaks and cleanup to naming conventions section#3164randomPoison wants to merge 2 commits intogoogle:mainfrom
randomPoison wants to merge 2 commits intogoogle:mainfrom
Conversation
mgeisler
approved these changes
Apr 20, 2026
Collaborator
mgeisler
left a comment
mgeisler
left a comment
There was a problem hiding this comment.
Thanks for condensing this!
auto-merge was automatically disabled
April 21, 2026 20:01
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweaks and feedback to the "Naming Conventions" section of Idiomatic based on my experience teaching the class, mostly focusing on making the slides more concise. Related to #3157, which also attempts to trim the section by removing some slides that I don't think are necessary. As noted in that PR, I think the section is overly long and would benefit from being a quicker tour of naming conventions, without needing to spend a lot of time on any of the slides.